fix: misleading error message about missing config when opening new file #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a false alarm that says a config file cannot be found when the language server tries to open a file for the first time. We actually make two calls to `openClientFile()`. 1. In the first call, if the project doesn't already exist, the method will create a project but it will not return the config filename. 2. In the second call, since the project has already been created, the call to `openClientFile()` should succeed and we should receive a config filename. If we don't receive one then it is an error, and we should log message here instead of logging it in step (1).
ayazhafiz
approved these changes
Oct 9, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a false alarm that says a config file cannot be found
when the language server tries to open a file for the first time.
We actually make two calls to
openClientFile().will create a project but it will not return the config filename.
the call to
openClientFile()should succeed and we should receive aconfig filename. If we don't receive one then it is an error, and we
should log message here instead of logging it in step (1).