Skip to content

Pressure.PoundForcePerSquareInch vs Pressure.Psi redundant and inconsistent #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BrandonLWhite opened this issue Jan 4, 2017 · 3 comments

Comments

@BrandonLWhite
Copy link
Contributor

There are 2 Pressure units for what I think is technically the same thing: Pounds per square inch

PoundForcePerSquareInch is defined with a conversion factor of 6894.75788951576 and Psi is 6.89464975179*1e3.

I cannot determine where the Psi factor came from. I cannot locate this in any references I checked. While these are certainly very close, they are different.

I believe the following issues should be addressed:

@angularsen
Copy link
Owner

Funny you should bring that up, I just realized the same thing the other day I was working with pressure. I kind of brushed it off as "meh", but I'm glad you are addressing this. I didn't realize the conversion functions were different, that's not good.

I agree with all your points. Would you care to do a PR?

@angularsen
Copy link
Owner

angularsen commented Jan 4, 2017

By the way, the Psi unit should be marked as [Obsolete] and added to #180 for removal in next major version bump. See how Volume.Teaspoon is marked as obsolete.

@BrandonLWhite
Copy link
Contributor Author

Ok great. Sure I can do this.

BrandonLWhite added a commit to BrandonLWhite/UnitsNet that referenced this issue Jan 6, 2017
… Alterered conversion factor for Pressure.PoundForcePerSquareInch to be exact and added "psi" as preferred en-US abbreviation. Issue angularsen#215
angularsen added a commit that referenced this issue Jan 7, 2017
Deprecated Pressure.Psi in favor of Pressure.PoundForcePerSquareInch

Alterered conversion factor for Pressure.PoundForcePerSquareInch to be exact and added "psi" as preferred en-US abbreviation. Issue #215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants