-
Notifications
You must be signed in to change notification settings - Fork 393
Pressure.PoundForcePerSquareInch vs Pressure.Psi redundant and inconsistent #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Funny you should bring that up, I just realized the same thing the other day I was working with pressure. I kind of brushed it off as "meh", but I'm glad you are addressing this. I didn't realize the conversion functions were different, that's not good. I agree with all your points. Would you care to do a PR? |
By the way, the Psi unit should be marked as |
Ok great. Sure I can do this. |
… Alterered conversion factor for Pressure.PoundForcePerSquareInch to be exact and added "psi" as preferred en-US abbreviation. Issue angularsen#215
Deprecated Pressure.Psi in favor of Pressure.PoundForcePerSquareInch Alterered conversion factor for Pressure.PoundForcePerSquareInch to be exact and added "psi" as preferred en-US abbreviation. Issue #215
There are 2 Pressure units for what I think is technically the same thing: Pounds per square inch
PoundForcePerSquareInch is defined with a conversion factor of 6894.75788951576 and Psi is 6.89464975179*1e3.
I cannot determine where the Psi factor came from. I cannot locate this in any references I checked. While these are certainly very close, they are different.
I believe the following issues should be addressed:
There should not be 2 different unit entries for this.
Psi should be removed and the "psi" abbreviation added to PoundForcePerSquareInch. I further think "psi" should be the first/preferred abbreviation.
The conversion factor for PoundForcePerSquareInch should be adjusted to 6.894757293168e3. This isn't very critical, but so long as the current conversion has a large number of significant digits, they should be correct. See http://math.stackexchange.com/questions/64880/pascals-to-psi-formula and https://en.wikipedia.org/wiki/Pounds_per_square_inch
The text was updated successfully, but these errors were encountered: