Skip to content

Re-enable and fix msbuild warnings #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
angularsen opened this issue Sep 28, 2018 · 0 comments · Fixed by #617
Closed

Re-enable and fix msbuild warnings #495

angularsen opened this issue Sep 28, 2018 · 0 comments · Fixed by #617
Assignees
@angularsen
Labels
difficulty-easy good first issue

Comments

@angularsen
Copy link
Owner

Wait for v4 branch to merge before starting on this.

Due to thousands of msbuild warnings, several msbuild warnings are muted.
The most prominent ones are due to missing XML documentation on public types and methods.

We should address this warning and the others that are currently disabled, but right now working on v4 branch it just gets in the way.

At least these, but check the other .csproj files too:

UnitsNet/UnitsNet/UnitsNet.Common.props

Line 27 in 0211ecc

<NoWarn>CS1701;CS1702;CS1705;CS0618;CS0809</NoWarn>

UnitsNet/UnitsNet.WindowsRuntimeComponent/UnitsNet.WindowsRuntimeComponent.csproj

Line 21 in 0211ecc

<NoWarn>CS1701;CS1702;CS1705;CS0618;CS0809;2008</NoWarn>

@angularsen angularsen changed the title Re-enable msbuild warnings Re-enable and fix msbuild warnings Sep 28, 2018
angularsen added a commit that referenced this issue Sep 28, 2018
@angularsen
Ignore thousands of warnings about no xml doc
5e8ac05 
We should address this, but right now this is just a
big distraction and spam.
Added issue to look at this later:
#495
@angularsen angularsen self-assigned this Feb 25, 2019
@angularsen angularsen mentioned this issue Feb 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angularsen angularsen

Labels
difficulty-easy good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix msbuild warnings, re-enable and treat all as errors angularsen/UnitsNet
1 participant
@angularsen