Deprecate more usage of QuantityType #1019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Continued from #864 |
tmilnthorp
commented
Jan 26, 2022
| @@ -43,16 +43,6 @@ public static partial class Quantity | |||
| Writer.WL(@" | |||
| }; | |||
|
|
|||
| // Used by the QuantityInfo .ctor to map a name to a QuantityType. Will be removed when QuantityType | |||
| // will be removed. | |||
| internal static readonly IDictionary<string, QuantityType> QuantityTypeByName = new Dictionary<string, QuantityType> | |||
There was a problem hiding this comment.
This was no longer used anywhere
tmilnthorp
commented
Jan 26, 2022
| @@ -585,7 +587,7 @@ public bool Equals({_quantity.Name} other, double tolerance, ComparisonType comp | |||
| /// <returns>A hash code for the current {_quantity.Name}.</returns> | |||
| public override int GetHashCode() | |||
| {{ | |||
| return new {{ QuantityType, Value, Unit }}.GetHashCode(); | |||
| return new {{ Info.Name, Value, Unit }}.GetHashCode(); | |||
There was a problem hiding this comment.
Matching implementation to main library
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
========================================
- Coverage 82.7% 82.7% -0.0%
========================================
Files 310 310
Lines 46586 46585 -1
========================================
- Hits 38526 38525 -1
Misses 8060 8060
Continue to review full report at Codecov.
|
|
CodeCov is really hating me today. Love the error for a deleted/unused line of code: "Your changes would remove code coverage for this line" 😄 |
angularsen
approved these changes
Jan 26, 2022
| { "VolumetricHeatCapacity", QuantityType.VolumetricHeatCapacity }, | ||
| { "WarpingMomentOfInertia", QuantityType.WarpingMomentOfInertia }, | ||
| }; | ||
|
|
|
Nuget should be out shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we had only partially deprecated QuantityType. I think this hits all of them.