Add lb/mil² and Wh/lbs #1092
Merged
Add lb/mil² and Wh/lbs #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1092 +/- ##
======================================
Coverage 85% 85%
======================================
Files 315 315
Lines 48697 48751 +54
======================================
+ Hits 41564 41618 +54
Misses 7133 7133
Continue to review full report at Codecov.
|
angularsen
approved these changes
May 30, 2022
| @@ -51,6 +53,8 @@ public class PressureTests : PressureTestsBase | |||
|
|
|||
| protected override double PoundsForcePerSquareInchInOnePascal => 1.450377377302092e-4; | |||
|
|
|||
| protected override double PoundsForcePerSquareMilInOnePascal => 1.450377377302092e-10; | |||
There was a problem hiding this comment.
Could not find a converter source to verify, but since mil is 1e-3 inch and square inch is 1e-6, then this seems reasonable.
| @@ -22,6 +22,11 @@ public class SpecificEnergyTests : SpecificEnergyTestsBase | |||
| protected override double MegawattHoursPerKilogramInOneJoulePerKilogram => 2.77777778e-10; | |||
| protected override double GigawattHoursPerKilogramInOneJoulePerKilogram => 2.77777778e-13; | |||
|
|
|||
| protected override double WattHoursPerPoundInOneJoulePerKilogram => 1.2599788055556e-4; | |||
This was referenced May 30, 2022
|
Nuget should be out in a few minutes. |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091 (PoundForcePerSquareMil
Fixes #1090 (WattHourPerPound)