Skip to content

Update .NET Framework to 4.8 #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sequc82
Copy link
Contributor

@sequc82 sequc82 commented Dec 11, 2019

.NET 4.0 is not compatible with IReadOnlyList. interested in updating .NET Framework to make compatible.

@codecov-io
Copy link

Codecov Report

Merging #728 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files         170      170           
  Lines       38375    38375           
=======================================
  Hits        22454    22454           
  Misses      15921    15921

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305ef08...6a5b434. Read the comment docs.

@angularsen
Copy link
Owner

angularsen commented Dec 11, 2019

I hate to kill your initiative :-) But this is unfortunately a breaking change for users out there stuck on any versions below .NET 4.6.1.

I'm totally open to discuss moving the lowest version up, but we would have to target v5 for a change like this. #563

One one hand, we can write cleaner and better code with newer .NET versions and really the only target we typically need is netstandard2.0. That supports pretty much all commonly used .NET runtimes and versions, including the .NET framework down to 4.6.1. https://github.com/dotnet/standard/blob/master/docs/versions.md

On the other hand, it costs us very little to support consumers who actually are stuck on older .NET versions and all the legwork of supporting net40 is already done. I wouldn't make this change only to get types like IReadOnlyList, but I'm sure there are some real benefits to dropping net40. I'd have to research it a bit more.

I wish there was a way to get statistics on what targets our consumers use, but I don't know of anything like that.

If you want, you can start a discussion on #563 or at least add it to the list of things to consider. There isn't a lot of momentum for v5 yet, but the new UnitSystem was one of the things we wanted to get out on that version.

@sequc82
Copy link
Contributor Author

sequc82 commented Dec 11, 2019

I appreciate the feedback! I'll look into #563 and close this for now.

@sequc82 sequc82 closed this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants