Minor cleanup of windows build script and venv configuration #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is helpful. Add the usage of the |
MaxJPRey
approved these changes
Jan 10, 2022
|
Add a windows batch file file and this is good to go. |
MaxJPRey
reviewed
Jan 10, 2022
| @@ -0,0 +1,7 @@ | |||
| @echo off | |||
| setlocal | |||
There was a problem hiding this comment.
@dnwillia-ansys Out of curiosity, why do we need to use setlocal here as we don't define any variable?
There was a problem hiding this comment.
Yeah, it's technically not needed here. Force of habit from my side. I can remove it if you feel it should not be there.
There was a problem hiding this comment.
That's fine by me. Thanks Dan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.