feat: Find and Fix Stitch Faces/Missing Faces Enhancements #1953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added find_and_fix_stitch_faces added applicable tests (comprehensive and standard)
This was
linked to
issues
May 1, 2025
added 4 commits
May 1, 2025 13:31
switching default value on find and fix to None
…ub.com/ansys/pyansys-geometry into feat/find_fix_stitch_faces_enhancement
added 3 commits
May 1, 2025 14:17
jacobrkerstetter
changed the title
|
Hi @jacobrkerstetter! Let's wait for #1912 to be merged and then you can adapt your implementation to the new structure. Sounds good? |
… feat/find_fix_stitch_faces_enhancement
… feat/find_fix_stitch_faces_enhancement # Conflicts: # src/ansys/geometry/core/tools/repair_tools.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
+ Coverage 90.35% 90.45% +0.10%
==========================================
Files 123 123
Lines 9830 9810 -20
==========================================
- Hits 8882 8874 -8
+ Misses 948 936 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
requested changes
May 8, 2025
umutsoysalansys
previously approved these changes
May 8, 2025
RobPasMue
requested changes
May 8, 2025
| @@ -285,6 +285,32 @@ def test_fix_interference(modeler: Modeler): | |||
| assert result.success is True | |||
|
|
|||
There was a problem hiding this comment.
I am missing some tests using angles and distances for the new APIs added.. @RyanJWard @syscordan -- could you guys maybe take care of that as part of this PR (I think @jacobrkerstetter is out for the rest of the week)?
added 4 commits
May 14, 2025 08:27
… feat/find_small_faces_enhancements # Conflicts: # src/ansys/geometry/core/tools/repair_tools.py
… feat/find_fix_stitch_faces_enhancement
…om/ansys/pyansys-geometry into feat/find_fix_stitch_faces_enhancement # Conflicts: # src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py # src/ansys/geometry/core/tools/repair_tools.py
|
There are a few bugs in SC and CoreService holding this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added model for testing stitching many faces
added find_and_fix_stitch_faces
added applicable tests (comprehensive and standard)
Issue linked
#1947
#1949
#1950
Checklist
feat: extrude circle to cylinder)