feat: migrate to Ruff for code linting and formatting #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgepiloto
commented
Sep 3, 2024
| src/ansys/dpf/gatebin/| | ||
| src/ansys/grpc/dpf/| | ||
| ) | ||
| exclude: > |
There was a problem hiding this comment.
Without fixing this, pre-commit was ignoring all files.
jorgepiloto
force-pushed
the
feat/ruff
branch
from
b7a1720 to
e6603df
Compare
jorgepiloto
force-pushed
the
feat/ruff
branch
from
e6603df to
46a88ee
Compare
|
As discussed in private, we will enable step by step the different rules for better fixing any issues. Despite the rules being deactivated, Ruff formatter still provides all current capabilities. Just see the rules as "extras" or "plugins". |
jorgepiloto
commented
Sep 4, 2024
|
|
||
| - repo: https://github.com/codespell-project/codespell | ||
| rev: v2.3.0 | ||
| hooks: | ||
| - id: codespell | ||
| args: ["--ignore-words=ignore_words.txt"] | ||
| args: ["--ignore-words=./doc/styles/Vocab/ANSYS/accept.txt"] |
There was a problem hiding this comment.
Unifying all ignore/accepted words in the "accept.txt" file
doc/styles/Vocab/ANSYS/accept.txt
Outdated
There was a problem hiding this comment.
I just sorted and uniq this file
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1727 +/- ##
==========================================
+ Coverage 85.67% 87.05% +1.37%
==========================================
Files 83 83
Lines 9937 9937
==========================================
+ Hits 8514 8651 +137
+ Misses 1423 1286 -137 |
PProfizi
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request drops support for black, isort, and flake in favor of Ruff, which contains all previous tools and more!
This linter and formatter is really fast for big projects. Its rules are able to identify common issues and format files in just a few milliseconds.
This pull-request is related with #1722.