Fix update of empty vectors #2285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2285 +/- ##
==========================================
+ Coverage 83.77% 83.97% +0.20%
==========================================
Files 90 90
Lines 10399 10399
==========================================
+ Hits 8712 8733 +21
+ Misses 1687 1666 -21 |
rafacanton
approved these changes
May 14, 2025
rafacanton
reviewed
May 14, 2025
tests/test_dpf_vector.py
Outdated
| assert np.allclose(field.get_entity_data(1), [0]) | ||
|
|
||
|
|
||
| @conftest.raises_for_servers_version_under("5.0") |
There was a problem hiding this comment.
@cbellot000 6.0 to also cover 2023R1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty (nullptr) vectors can be updated to non empty vectors of size 0 when using gRPC.
This can, for example, cause a property field to have a non empty data pointer after accessing the data pointer in python.
closing #2274