-
Notifications
You must be signed in to change notification settings - Fork 5
html export: improve custom url handling #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update html_exporter.py Update html_exporter.py
Update test_html_exporter.py
This reverts commit bb30ffa.
2b05ef4
to
7fbbac3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
+ Coverage 81.08% 81.18% +0.09%
==========================================
Files 28 28
Lines 7888 7880 -8
Branches 1464 1460 -4
==========================================
+ Hits 6396 6397 +1
+ Misses 1026 1022 -4
+ Partials 466 461 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves custom URL handling in the HTML exporter by refactoring tests to use dynamically generated URLs from the ADR instance instead of hardcoded legacy URLs. The changes remove support for legacy literal paths (/static/
and /media/
) in favor of configured custom URLs, making the exporter more flexible and less dependent on hardcoded assumptions.
- Replaces hardcoded
/static/
and/media/
paths in tests with dynamic URLs fromadr_serverless.static_url
andadr_serverless.media_url
- Removes legacy literal path support from the HTML exporter implementation
- Simplifies URL pattern matching by focusing on configured custom URLs and versioned Ansys paths
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
tests/serverless/test_html_exporter.py | Updates all test cases to use dynamic URLs from ADR instance instead of hardcoded paths |
tests/serverless/test_adr.py | Updates integration test to use dynamic static URL for consistency |
src/ansys/dynamicreporting/core/serverless/html_exporter.py | Removes legacy literal path support and simplifies URL pattern matching logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.