Skip to content

Conversation

viseshrp
Copy link
Collaborator

No description provided.

Update html_exporter.py

Update html_exporter.py
Update test_html_exporter.py
This reverts commit bb30ffa.
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.18%. Comparing base (35cfa51) to head (f7e0ef0).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   81.08%   81.18%   +0.09%     
==========================================
  Files          28       28              
  Lines        7888     7880       -8     
  Branches     1464     1460       -4     
==========================================
+ Hits         6396     6397       +1     
+ Misses       1026     1022       -4     
+ Partials      466      461       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves custom URL handling in the HTML exporter by refactoring tests to use dynamically generated URLs from the ADR instance instead of hardcoded legacy URLs. The changes remove support for legacy literal paths (/static/ and /media/) in favor of configured custom URLs, making the exporter more flexible and less dependent on hardcoded assumptions.

  • Replaces hardcoded /static/ and /media/ paths in tests with dynamic URLs from adr_serverless.static_url and adr_serverless.media_url
  • Removes legacy literal path support from the HTML exporter implementation
  • Simplifies URL pattern matching by focusing on configured custom URLs and versioned Ansys paths

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/serverless/test_html_exporter.py Updates all test cases to use dynamic URLs from ADR instance instead of hardcoded paths
tests/serverless/test_adr.py Updates integration test to use dynamic static URL for consistency
src/ansys/dynamicreporting/core/serverless/html_exporter.py Removes legacy literal path support and simplifies URL pattern matching logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@viseshrp viseshrp enabled auto-merge (squash) September 23, 2025 21:26
@viseshrp viseshrp merged commit 54760aa into main Sep 24, 2025
16 checks passed
@viseshrp viseshrp deleted the vrajendr/hx-imp branch September 24, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants