fix: Unavaialble field data for some surfaces. #4345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
mkundu1,
seanpearsonuk and
hpohekar
as code owners
|
This is a tricky one where I'm not sure what the best behaviour would be. Please make sure that we are also documenting the API behaviour clearly. IMHO that's more important than runtime warnings. |
seanpearsonuk
approved these changes
Aug 4, 2025
hpohekar
approved these changes
Aug 4, 2025
prmukherj
commented
Aug 4, 2025
prmukherj
added a commit
that referenced
this pull request
Aug 4, 2025
Sometimes some surfaces might be created but field data on them might not be available. For example please refer the issue: ansys/pyfluent-visualization#552 Now we are getting and returning the field data as empty array for these surfaces, just like Fluent does. We are additionally providing an warning that theses surfaces does not have field data. <img width="479" height="275" alt="image" src="https://github.com/user-attachments/assets/85c39d3b-70ae-4cd5-a8cc-2ce4d1b21746" /> We need to patch this with v0.34 to address an user bug. --------- Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes some surfaces might be created but field data on them might not be available. For example please refer the issue: ansys/pyfluent-visualization#552
Now we are getting and returning the field data as empty array for these surfaces, just like Fluent does. We are additionally providing an warning that theses surfaces does not have field data.
We need to patch this with v0.34 to address an user bug.