Reorganizing the headers #1689
Merged
Reorganizing the headers #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/CD
Revathyvenugopal162
approved these changes
Dec 14, 2022
Co-authored-by: Revathy Venugopal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1689 +/- ##
==========================================
+ Coverage 85.23% 85.27% +0.03%
==========================================
Files 45 45
Lines 7506 7506
==========================================
+ Hits 6398 6401 +3
+ Misses 1108 1105 -3 |
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
reviewed
Dec 14, 2022
PipKat
approved these changes
Dec 14, 2022
germa89
commented
Dec 14, 2022
Thank you a lot Kathy! Co-authored-by: Kathy Pippert <[email protected]>
germa89
commented
Dec 14, 2022
germa89
commented
Dec 15, 2022
germa89
commented
Dec 15, 2022
|
Regarding #1688 I have decided to NOT join both sections. The WSL section is more specific than docker and it has its complexities. |
PipKat
reviewed
Dec 15, 2022
PipKat
reviewed
Dec 15, 2022
PipKat
reviewed
Dec 15, 2022
germa89
commented
Dec 15, 2022
germa89
commented
Dec 15, 2022
Co-authored-by: Kathy Pippert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By popular demand.
@PipKat although there is some renaming, I did not change anything in API directory. Have a look at the other files (docker, wsl, etc)
I'm merging tonight so if you cannot have a look today, feel free to open a later PR.
@Revathyvenugopal162 ... Finally you got it! xD
Close #1688
Close #1620