Skip to content

Update index.html #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update index.html #86

wants to merge 1 commit into from

Conversation

mengrang
Copy link

@mengrang mengrang commented Aug 10, 2025

Summary by Sourcery

Annotate the author list in index.html with superscript markers and add a legend to clarify core contributors and corresponding authors.

Enhancements:

  • Add superscript indices to specific authors in the author list
  • Insert a centered legend explaining the meaning of each superscript number

Copy link

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

Copy link

sourcery-ai bot commented Aug 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances the author section in index.html by adding superscript markers to indicate core and corresponding authors, along with an explanatory footnote, and adjusts minor HTML formatting for proper display.

File-Level Changes

Change Details Files
Annotate authors with role-based superscripts and add explanatory footnote
  • Insert 1 after Rang Meng to mark as core contributor
  • Insert 2 after Yuming Li and Chenguang Ma to mark as corresponding authors
  • Add a centered paragraph defining superscript roles
ai/echomimic_v3/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mengrang - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `ai/echomimic_v3/index.html:72` </location>
<code_context>
-    <a>Yuming Li</a>
-    <a>Chenguang Ma</a><br>
+    <a>Yuming Li</a><sup>2</sup>
+    <a>Chenguang Ma</a><br><sup>2</sup>
     <span style="font-size: 1.0em; margin-top: 0.8em; line-height:2;">
       <a>Terminal Technology Department, Alipay, Ant Group.</a>
</code_context>

<issue_to_address>
Superscript placement after <br> may affect visual alignment.

Moving <sup>2</sup> after the <br> may cause it to appear misaligned. Place the superscript immediately after the author's name to maintain proper alignment.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
    <a>Yuming Li</a><sup>2</sup>
    <a>Chenguang Ma</a><br><sup>2</sup>
=======
    <a>Yuming Li</a><sup>2</sup>
    <a>Chenguang Ma</a><sup>2</sup><br>
>>>>>>> REPLACE

</suggested_fix>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +71 to +72
<a>Yuming Li</a><sup>2</sup>
<a>Chenguang Ma</a><br><sup>2</sup>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Superscript placement after
may affect visual alignment.

Moving 2 after the
may cause it to appear misaligned. Place the superscript immediately after the author's name to maintain proper alignment.

Suggested change
<a>Yuming Li</a><sup>2</sup>
<a>Chenguang Ma</a><br><sup>2</sup>
<a>Yuming Li</a><sup>2</sup>
<a>Chenguang Ma</a><sup>2</sup><br>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant