-
Notifications
You must be signed in to change notification settings - Fork 1
Update index.html #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enhances the author section in index.html by adding superscript markers to indicate core and corresponding authors, along with an explanatory footnote, and adjusts minor HTML formatting for proper display. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mengrang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `ai/echomimic_v3/index.html:72` </location>
<code_context>
- <a>Yuming Li</a>
- <a>Chenguang Ma</a><br>
+ <a>Yuming Li</a><sup>2</sup>
+ <a>Chenguang Ma</a><br><sup>2</sup>
<span style="font-size: 1.0em; margin-top: 0.8em; line-height:2;">
<a>Terminal Technology Department, Alipay, Ant Group.</a>
</code_context>
<issue_to_address>
Superscript placement after <br> may affect visual alignment.
Moving <sup>2</sup> after the <br> may cause it to appear misaligned. Place the superscript immediately after the author's name to maintain proper alignment.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
<a>Yuming Li</a><sup>2</sup>
<a>Chenguang Ma</a><br><sup>2</sup>
=======
<a>Yuming Li</a><sup>2</sup>
<a>Chenguang Ma</a><sup>2</sup><br>
>>>>>>> REPLACE
</suggested_fix>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
<a>Yuming Li</a><sup>2</sup> | ||
<a>Chenguang Ma</a><br><sup>2</sup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Superscript placement after
may affect visual alignment.
Moving 2 after the
may cause it to appear misaligned. Place the superscript immediately after the author's name to maintain proper alignment.
<a>Yuming Li</a><sup>2</sup> | |
<a>Chenguang Ma</a><br><sup>2</sup> | |
<a>Yuming Li</a><sup>2</sup> | |
<a>Chenguang Ma</a><sup>2</sup><br> |
Summary by Sourcery
Annotate the author list in index.html with superscript markers and add a legend to clarify core contributors and corresponding authors.
Enhancements: