java runtime: add module-info.java and multi-release build to support… #4137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2946 by adding module-info.java to antlr-runtime module of the project. This is done as "multi-release jar" which allows to specify multiple versions of classes for different java versions. In this case the module is compiled for java 8 with java 9 classes stored in META-INF/versions/9.
Module-info.java exports module named
org.antlr.antlr.runtime
. This differs from the original automatic-module-name (org.antlr.antlr4.runtime
) because JPMS doesn't like trailing digits in names.Module exports all packages except
org.antlr.v4.runtime.tree.pattern
andorg.antlr.v4.runtime.tree.xpath
. Please let me know if these are used outside the module and should be included as well.