-
Notifications
You must be signed in to change notification settings - Fork 933
arrow-cast: Support cast to Dictionary<_, FixedSizeBinary>
and add FixedSizeBinaryDictionaryBuilder
#6666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests please
Marking as draft as this is not waiting on any more feedback -- please mark it as ready for review when it is time. Extending the existing tests should be straightforward -- let us know if you need help @metalmatze Thanks for the contribution |
Thanks, everyone! |
Perhaps you could follow the model of arrow-rs/arrow-cast/src/cast/mod.rs Line 6795 in 3ee5048
|
1bf1315
to
c9aa2b6
Compare
I've added tests and it's ready for another round of reviews! |
Dictionary<_, FixedSizeBinary>
and add FixedSizeBinaryDictionaryBuilder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this contribution @metalmatze
In order to unstall this PR as it has been sitting for so long, I took the liberty of pushing a few commits to this PR:
- Add test that cast deduplicated values
- A doc example
- Some fixes for clippy
- An error test for values of the wrong length
Thank you for taking it across the finish line! Much appreciated! LGTM and it's great to learn from. |
…`FixedSizeBinaryDictionaryBuilder` (apache#6666) * arrow-cast: Support FixedSizeBinary packing * Add fixed_size_binary_dictionary_builder.rs * Improve tests / fmt * clippy * Add a documentation example * Add test for error, improve message * fix link in doc --------- Co-authored-by: Andrew Lamb <[email protected]>
Which issue does this PR close?
Closes #6665.
Rationale for this change
The added code seems to be where the casting and packing is handled.
What changes are included in this PR?
Are there any user-facing changes?
No, I don't think so.