Skip to content

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented May 30, 2025

Which issue does this PR close?

Closes #7567.

Rationale for this change

Update to latest parquet format.

What changes are included in this PR?

Re-generate format.rs and make any needed changes to allow compilation. No support for new logical types is added.

Are there any user-facing changes?

yes

@etseidl etseidl added parquet Changes to the parquet crate enhancement Any new improvement worthy of a entry in the changelog api-change Changes to the arrow API labels May 30, 2025
@etseidl etseidl added the next-major-release the PR has API changes and it waiting on the next major version label May 31, 2025
@etseidl etseidl marked this pull request as ready for review May 31, 2025 19:50
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it -- thank you @etseidl

@etseidl etseidl merged commit e930492 into apache:main Jun 27, 2025
16 checks passed
@alamb
Copy link
Contributor

alamb commented Jun 27, 2025

woohoo! I am predicting it is going to be a good (high velocity) day in arrow-rs on main

@etseidl
Copy link
Contributor Author

etseidl commented Jun 27, 2025

woohoo! I am predicting it is going to be a good (high velocity) day in arrow-rs on main

As I learn the inner working of the archery tests 😛

Trying to track down why the js->rust integration is now failing 😭

@alamb
Copy link
Contributor

alamb commented Jun 27, 2025

As I learn the inner working of the archery tests 😛

Trying to track down why the js->rust integration is now failing 😭

I have seen it intermittently fail recently -- does it pass if you rerun the test?

@etseidl
Copy link
Contributor Author

etseidl commented Jun 27, 2025

As I learn the inner working of the archery tests 😛
Trying to track down why the js->rust integration is now failing 😭

I have seen it intermittently fail recently -- does it pass if you rerun the test?

Hmm, yes. Back to merging 😄

@alamb
Copy link
Contributor

alamb commented Jun 27, 2025

🤔 we should probably report/fix that, but I haven't had the energy to do so -- which now that I type that sounds a lot like an excuse 😆

@etseidl
Copy link
Contributor Author

etseidl commented Jun 27, 2025

🤔 we should probably report/fix that, but I haven't had the energy to do so -- which now that I type that sounds a lot like an excuse 😆

I just kicked off another run, let's see what that does. If the error keeps cropping up I'll dig deeper.

@etseidl etseidl deleted the update_parquet_format branch June 27, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API enhancement Any new improvement worthy of a entry in the changelog next-major-release the PR has API changes and it waiting on the next major version parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the parquet thrift definitions
3 participants