[Variant] Implement DataType::Boolean support for cast_to_variant kernel
#8085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdf-jkl
commented
Aug 7, 2025
|
I merged up to resolve a conflict |
…into bool-to-variant
|
@alamb Ready to merge and close the issue? |
|
Yes, thank you @sdf-jkl |
alamb
changed the title
DataType::Boolean support for cast_to_variant kernelDataType::Boolean support for cast_to_variant kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DataType::Booleansupport forcast_to_variantkernel #8052.Rationale for this change
Adds boolean conversion to the cast_to_variant kernel
What changes are included in this PR?
non_generic_conversionmacro for converting data types that do not require generic type in the method.cast_conversionmacro togeneric_conversionto make a distinction.DataType::BooleantoVariant:BooleanTrue/FalseAre these changes tested?
Yes, added a test for casting Boolean array to Variant
Are there any user-facing changes?
New conversion to
cast_to_variantkernel