Skip to content

Conversation

feniljain
Copy link
Contributor

Which issue does this PR close?

Are these changes tested?

Yes

Notes

From this comment:

/// # Notes
/// If the input array element is null, the corresponding element in the
/// output `VariantArray` will also be null (not `Variant::Null`).

I think we need to make a variant array of nulls, do correct me if I am wrong here, and a Variant::Null needs to be returned 😅

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this makes sense to me -- thank you @feniljain

@alamb alamb changed the title feat(variant): add DataType::Null support to cast_to_variant [Varaint]: add DataType::Null support to cast_to_variant Aug 11, 2025
@alamb alamb changed the title [Varaint]: add DataType::Null support to cast_to_variant [Varaint]: add DataType::Null support to cast_to_variant Aug 11, 2025
@alamb
Copy link
Contributor

alamb commented Aug 13, 2025

I merged up to resolve a conflict

@github-actions github-actions bot added the parquet-variant parquet-variant* crates label Aug 13, 2025
@alamb alamb merged commit f3a4698 into apache:main Aug 13, 2025
11 checks passed
@alamb
Copy link
Contributor

alamb commented Aug 13, 2025

Thanks again @feniljain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet-variant parquet-variant* crates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Variant]: Implement DataType::Null support for cast_to_variant kernel
2 participants