-
Notifications
You must be signed in to change notification settings - Fork 1k
[avro] Support all default types for avro schema's record field #8210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jecsand838 do you have time to review this PR? |
@yongkyunlee Thanks for making this contribution! LMGTM, just had one nit. |
Thanks! Addressed the comment |
Thanks @yongkyunlee @jecsand838 and @mbrobbel 🚀 |
Shouldn't we wait until after 56.2.0 (because this is a breaking change)? |
Ah, I just learned this isn't public yet. |
Indeed -- but thank you for the review. I think the idea is that we'll bash on with new feature development / breaking API changes, etc until we are satisfied this crate is ready, and then we'll start subjecting it to the same API versioning as other crates. |
Which issue does this PR close?
Closes #8209
Rationale for this change
In the Field struct definition
type is of type
Schema
whereas default is of typestr
. The default should be supported for all types (e.g. int, array, map, nested record), so we should make it more lenient.More details on reproduction is mentioned in the Github Issue.
What changes are included in this PR?
Relaxation of default type of avro scheam Field.
Are these changes tested?
Added a unit test.
Are there any user-facing changes?
It affects
pub struct Field
ofarrow-avro
package, but the impact should be minimal as thedefault
attribute is not being used.