Skip to content

Conversation

zachschuermann
Copy link
Contributor

@zachschuermann zachschuermann commented Aug 28, 2025

Which issue does this PR close?

What changes are included in this PR?

pin comfy-table to release prior to 7.2.0's MSRV bump to 1.85 - included a TODO to unpin after arrow bumps to 1.85

(context FWIW: caught in delta_kernel MSRV CI)

Are these changes tested?

validated MSRV with cargo-msrv:

# now passes
cargo msrv --path arrow-cast/ verify --rust-version 1.84 --all-features

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 28, 2025
@mbrobbel mbrobbel merged commit f337933 into apache:main Aug 29, 2025
28 checks passed
@mbrobbel
Copy link
Member

Thanks @zachschuermann

@scovich
Copy link
Contributor

scovich commented Aug 29, 2025

Would it make sense to ship a point release for this? The current release is unusable because of contradictory MSRV.
To resolve the contradiction, either the MSRV needs to bump or this fix here needs to ship.

@zachschuermann zachschuermann deleted the pin-comfy-table branch August 29, 2025 16:31
@mbrobbel
Copy link
Member

Would it make sense to ship a point release for this? The current release is unusable because of contradictory MSRV. To resolve the contradiction, either the MSRV needs to bump or this fix here needs to ship.

I don't think it really matters. For downstream users without specific MSRV requirements there is no problem, and users with the same MSRV requirements can just pin the version - like we did here. The benefit of a release is that we prevent the impacted users from having to manually pin and/or to avoid an unintended bump of this dependency.

@scovich
Copy link
Contributor

scovich commented Aug 29, 2025

users with the same MSRV requirements can just pin the version - like we did here. The benefit of a release is that we prevent the impacted users from having to manually pin and/or to avoid an unintended bump of this dependency.

Confirmed that delta-kernel-rs was able to pin the version by manually adding it as a dependency (even tho it's not a direct dependency). Annoying but worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

comfy-table release 7.2.0 breaks MSRV
3 participants