Avoid panics and warnings when building avro without default features #8576
+97
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
mbrobbel
commented
Oct 9, 2025
| } | ||
|
|
||
| #[test] | ||
| // TODO: avoid requiring snappy for this file |
There was a problem hiding this comment.
There are some files without .snappy that still seem to require snappy, not sure if that's expected or if we should fix that?
There was a problem hiding this comment.
I noticed that as well. Not 100% why that's the case. My guess would be that it was an attempt at making the test files smaller.
We probably do want some of these files truly uncompressed testing purposes though.
mbrobbel
force-pushed
the
test-feature-gate
branch
from
8cb54a6 to
6c63f1a
Compare
mbrobbel
force-pushed
the
test-feature-gate
branch
from
6c63f1a to
f5f5602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None.
Rationale for this change
cargo -p arrow-avro test --no-default-featuresbuilds with warnings and panics because of missing features.What changes are included in this PR?
Add the required feature gates to avoid problems when building without default features.
Are these changes tested?
Tested:
cargo -p arrow-avro test --no-default-featuresAre there any user-facing changes?
No.