Skip to content

Fix doctests of parquet push decoded without default features #8577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix doctests of parquet push decoded without default features #8577

wants to merge 2 commits into from
+141 −128

Conversation

mbrobbel
Copy link
Member

@mbrobbel mbrobbel commented Oct 9, 2025

Which issue does this PR close?

None.

Rationale for this change

Make sure cargo test -p parquet --doc --no-default-features works.

What changes are included in this PR?

Feature gate some doc tests on the arrow feature in the parquet crate.

Are these changes tested?

cargo test -p parquet --doc --no-default-features

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet Changes to the parquet crate label Oct 9, 2025
etseidl
etseidl approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbrobbel! TIL #[doc] and r## 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etseidl etseidl etseidl approved these changes

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbrobbel @etseidl