GH-47500: [C++] Add QualifierAlignment to clang-format options #47501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What do you think @zanmato1984 ? |
|
(Could you use our PR template?) |
github-actions
bot
added
awaiting merge
zanmato1984
approved these changes
Sep 5, 2025
pitrou
force-pushed
the
gh47500-clang-format-qualifiers
branch
from
096f863 to
188cac6
Compare
pitrou
requested review from
lidavidm,
westonpace and
wgtmac
as code owners
|
I'll merge now. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit eb6b637. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
…pache#47501) Use the [QualifierAlignment](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#qualifieralignment) clang-format option to make our code style more uniform. * GitHub Issue: apache#47500 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the QualifierAlignment clang-format option to make our code style more uniform.