GH-46147: [C++] Implement GCS support in Meson #47568
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WillAyd
force-pushed
the
meson-add-s3
branch
from
fbf7739 to
5eec224
Compare
WillAyd
commented
Sep 15, 2025
| required: false, | ||
| ) | ||
|
|
||
| if not (gcs_common_dep.found() |
There was a problem hiding this comment.
This is some unfortunate indentation - opened an upstream issue at mesonbuild/meson#15032
github-actions
bot
added
awaiting committer review
WillAyd
force-pushed
the
meson-add-s3
branch
from
5eec224 to
8e54ffe
Compare
WillAyd
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
WillAyd
force-pushed
the
meson-add-s3
branch
2 times, most recently
from
3151a22 to
69e81f2
Compare
WillAyd
commented
Sep 18, 2025
WillAyd
commented
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This continues adding features to the Meson configuration (azure is already implemented)
What changes are included in this PR?
System-provided GCS can be leveraged to build optional GCS features. Note that this does not support Meson to automatically download GCS - GCS is a rather complicated CMake project and does not work well in the Meson/CMake subproject bridge. Another PR will have to implement that, due to its complexity (or ideally a Meson wrap for GCS is created)
Are these changes tested?
Yes
Are there any user-facing changes?
No