-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[UI] Fix group disable action for compute and disk offering #11602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11602 +/- ##
=========================================
Coverage 16.17% 16.17%
Complexity 13293 13293
=========================================
Files 5656 5656
Lines 498098 498100 +2
Branches 60423 60424 +1
=========================================
+ Hits 80568 80572 +4
+ Misses 408562 408561 -1
+ Partials 8968 8967 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UI build: ✔️ |
108422a
to
5f366a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bernardodemarco for testing the fix. I will look into System Offering group action as well and update the PR accordingly. |
@sudo87, ok, thanks! |
@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, verified in the QA env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
Description
This PR fixes Group Disable action for Compute and Disk offering, need to pass Inactive in update API payload.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested it locally by disabling multiple/single disk and compute offering from UI.
How did you try to break this feature and the system with this change?