Skip to content

Conversation

sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Sep 10, 2025

Description

This PR fixes Group Disable action for Compute and Disk offering, need to pass Inactive in update API payload.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested it locally by disabling multiple/single disk and compute offering from UI.

How did you try to break this feature and the system with this change?

@sudo87
Copy link
Collaborator Author

sudo87 commented Sep 10, 2025

@blueorangutan ui

@sudo87 sudo87 changed the title Fix bulk disable compute and disk offering [UI] Fix group disable action for compute and disk offering Sep 10, 2025
@blueorangutan
Copy link

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.17%. Comparing base (7044564) to head (e20a903).
⚠️ Report is 2 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #11602   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
  Complexity    13293    13293           
=========================================
  Files          5656     5656           
  Lines        498098   498100    +2     
  Branches      60423    60424    +1     
=========================================
+ Hits          80568    80572    +4     
+ Misses       408562   408561    -1     
+ Partials       8968     8967    -1     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11602 (QA-JID-744)

@sudo87 sudo87 changed the base branch from main to 4.20 September 10, 2025 06:55
Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified in the QA env that it is now possible to disable compute and disk offerings through group actions.

However, for system offerings, the state API parameter is not specified and their group actions is not working:

image

@sudo87
Copy link
Collaborator Author

sudo87 commented Sep 10, 2025

I verified in the QA env that it is now possible to disable compute and disk offerings through group actions.

However, for system offerings, the state API parameter is not specified and their group actions is not working:

image

Thanks @bernardodemarco for testing the fix. I will look into System Offering group action as well and update the PR accordingly.

@bernardodemarco
Copy link
Member

I will look into System Offering group action as well and update the PR accordingly.

@sudo87, ok, thanks!

@sudo87
Copy link
Collaborator Author

sudo87 commented Sep 10, 2025

@blueorangutan ui

@blueorangutan
Copy link

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11602 (QA-JID-746)

Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verified in the QA env

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants