-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added Extension for MaaS integration in CloudStack #11613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11613 +/- ##
============================================
+ Coverage 17.36% 17.38% +0.02%
- Complexity 15245 15282 +37
============================================
Files 5888 5891 +3
Lines 525831 526356 +525
Branches 64183 64270 +87
============================================
+ Hits 91298 91525 +227
- Misses 424227 424489 +262
- Partials 10306 10342 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@blueorangutan package |
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14951 |
e551ba1
to
3498519
Compare
@blueorangutan package |
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15000 |
@harikrishna-patnala shouldn’t this be externalised and added on request at configuration/runtime instead of in the main repo? I know we did some initial integration within the repo, I just wonder if we should continue like that? cc @rohityadavcloud |
Yeah we need not to continue adding like this @DaanHoogland but this will stand as a good example for baremetal provisionings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
Didn't test.
@blueorangutan package |
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15158 |
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
1 similar comment
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
82212f4
to
24bd0be
Compare
@blueorangutan package |
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15174 |
Description
This PR adds a new extension and script to support MaaS (https://canonical.com/maas) in CloudStack.
Doc PR : apache/cloudstack-documentation#561
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?