-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix qemu-img path in cloudstack sudoers #11614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a configuration issue in CloudStack's sudoers file where qemu-img is not accessible in OpenSUSE systems due to a different installation path. The fix adds /usr/bin/qemu-img
as an additional allowed command path alongside the existing /bin/qemu-img
path.
- Adds
/usr/bin/qemu-img
to the CLOUDSTACK command alias in the sudoers configuration - Maintains backward compatibility by keeping the existing
/bin/qemu-img
path
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@blueorangutan package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11614 +/- ##
=========================================
Coverage 16.17% 16.17%
+ Complexity 13297 13296 -1
=========================================
Files 5656 5656
Lines 498136 498136
Branches 60432 60432
=========================================
+ Hits 80583 80585 +2
+ Misses 408585 408583 -2
Partials 8968 8968
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14960 |
@blueorangutan test |
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
verified OK the /etc/sudoers.d/cloudstack-management has been updated
|
[SF] Trillian Build Failed (tid-14302) |
[SF] Trillian Build Failed (tid-14303) |
Merging based on approvals and tests |
[SF] Trillian test result (tid-14298)
|
[SF] Trillian test result (tid-14297)
|
Description
This PR adds another path for qemu-img. In Open SUSE,
/bin/qemu-img
doesn't exist and this results in a faulty system VM template configuration as of now.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?