Skip to content

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes #5350

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1859

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-2641)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35040 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5755-t2641-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Dec 13, 2021
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, how does this relate to the qemu-kvm-ev package? can/should we include that as well as a acceptable dependency?

@weizhouapache
Copy link
Member Author

lgtm, how does this relate to the qemu-kvm-ev package? can/should we include that as well as a acceptable dependency?

@DaanHoogland
debian/control has only impact on Debian-based systems, e.g. Ubuntu, Debian.

I have not tested Ubuntu 21.04 (which has qemu-system-x86 but does not have qemu-kvm) . Without this PR, cloudstack-agent cannot be installed.

@DaanHoogland
Copy link
Contributor

lgtm, how does this relate to the qemu-kvm-ev package? can/should we include that as well as a acceptable dependency?

@DaanHoogland debian/control has only impact on Debian-based systems, e.g. Ubuntu, Debian.

I have not tested Ubuntu 21.04 (which has qemu-system-x86 but does not have qemu-kvm) . Without this PR, cloudstack-agent cannot be installed.

ok, so the qemu-kvm-ev discussion only applies to redhat varieties? tnx

@weizhouapache
Copy link
Member Author

lgtm, how does this relate to the qemu-kvm-ev package? can/should we include that as well as a acceptable dependency?

@DaanHoogland debian/control has only impact on Debian-based systems, e.g. Ubuntu, Debian.
I have not tested Ubuntu 21.04 (which has qemu-system-x86 but does not have qemu-kvm) . Without this PR, cloudstack-agent cannot be installed.

ok, so the qemu-kvm-ev discussion only applies to redhat varieties? tnx

@DaanHoogland exactly.

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we'll need to maintain the arm build to have qemu-system-arm then.

@rohityadavcloud
Copy link
Member

LGTM, checked packages.ubuntu.com - this will ensure qemu-system/x86 is installed on ubuntu 21.04 and later.

@rohityadavcloud rohityadavcloud merged commit 9798fa0 into apache:4.16 Dec 30, 2021
@weizhouapache weizhouapache deleted the 4.16-qemu-system-x86-5.2 branch December 9, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants