Skip to content

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 13, 2025

Motivation and Context

Provide a way for native apps that embed a Cordova WebView to disable Cordova's Splash Screen.

This is not intended for apps created with Cordova CLI.

Description

Added showInitialSplashScreen method to return true by default.

Native apps that embed a Cordova WebView can override this method inside the Activity that extends CordovaActivity.

E.g.

override fun showInitialSplashScreen(): Boolean {
    return false
}

Testing

  • Built native app
  • Override method showInitialSplashScreen

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.24%. Comparing base (0190d2e) to head (ec074f5).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1824   +/-   ##
=======================================
  Coverage   72.24%   72.24%           
=======================================
  Files          23       23           
  Lines        1841     1841           
=======================================
  Hits         1330     1330           
  Misses        511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems okay, since we don't support splashscreen.show() on Android

@erisu erisu merged commit c2cf589 into apache:master Jul 16, 2025
11 checks passed
@erisu erisu deleted the feat/allow-embedded-not-show-splashscreen branch July 16, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants