fix: edge to edge/fullscreen margins #1847
Merged
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
With the changes added on #1817, when the app is in edge to edge mode or fullscreen, the left and right margin values are being read directly from the insets thus causing the webview to not take the full width/height in fullscreen or not be overlaid by navigation/gesture bar when rotation the device.
It's unclear to me whether this was intentional but, if it wasn't, this is an attempt to fix it to what I'd expect is the correct behavior.
Description
Testing
Created a dummy application and manually ran it on Android 10 and 16 and compared the results visually.
Current behavior:
Behavior after the fix on this PR:
Thanks Kepa for the help!
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)