-
Notifications
You must be signed in to change notification settings - Fork 994
White Screen of Death issue | Enhance WebView reload detection to handle empty title strings #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
White Screen of Death issue | Enhance WebView reload detection to handle empty title strings #1552
Conversation
One concern I have is how this would handle pages with |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 17 17
Lines 1944 1944
=======================================
Hits 1621 1621
Misses 323 323 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is the cordova master: https://github.com/apache/cordova-ios/blob/47f23d54ba261c8c554d5d1be9b5dbbc3af0e057/CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m We need the links to what Meteor is using now (which is likely not the apache:master). See history here: https://github.com/apache/cordova-ios/commits/master/CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m |
@abroa01 let's link to the meteor project for this too. |
Meteor uses
This confirms that the file being patched comes from |
Improves white screen of death prevention by checking for both nil and empty string titles when determining if WebView needs reloading.
This catches more edge cases where the WebView enters a broken state but has an empty title instead of nil.