Skip to content

Snowflake: support for object constants #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

Snowflake: support for object constants #1223

merged 1 commit into from
Apr 26, 2024

Conversation

jmhain
Copy link
Contributor

@jmhain jmhain commented Apr 15, 2024

The syntax of these is identical, as far as I can tell, to DuckDB's "array notation" for STRUCTs, so this reuses the parser's existing support.

@coveralls
Copy link

coveralls commented Apr 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8851532958

Details

  • 38 of 47 (80.85%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 89.204%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/duckdb.rs 1 2 50.0%
src/dialect/generic.rs 1 2 50.0%
src/dialect/mod.rs 1 2 50.0%
src/dialect/snowflake.rs 1 2 50.0%
tests/sqlparser_common.rs 33 38 86.84%
Totals Coverage Status
Change from base Build 8816095341: -0.02%
Covered Lines: 23227
Relevant Lines: 26038
💛 - Coveralls

universalmind303
universalmind303 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iffyio
Copy link
Contributor

iffyio commented Apr 26, 2024

@jmhain just a heads up that the MR has some conflicts to address.
cc @alamb changes LGTM for review!

alamb
alamb approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it -- thank you @jmhain and @iffyio

Once the conflicts get resolved I'll merge it

@jmhain jmhain force-pushed the sf-object-constant branch from a3134dc to e7d9cdc Compare April 26, 2024 16:43
@jmhain
Copy link
Contributor Author

jmhain commented Apr 26, 2024

Thanks @alamb, conflicts resolved!

@alamb alamb merged commit deaa6d8 into apache:main Apr 26, 2024
@alamb
Copy link
Contributor

alamb commented Apr 26, 2024

Thanks again

@jmhain jmhain deleted the sf-object-constant branch April 26, 2024 19:18
JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
@jmhain @JichaoS
Snowflake: support for object constants (apache#1223)
c2f24d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@universalmind303 universalmind303 universalmind303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmhain @coveralls @iffyio @alamb @universalmind303