Skip to content

Support for postgres String Constants with Unicode Escapes #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Jul 27, 2024

fixes #1354

@coveralls
Copy link

coveralls commented Jul 27, 2024

Pull Request Test Coverage Report for Build 10144845572

Details

  • 79 of 102 (77.45%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 89.184%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/generic.rs 1 2 50.0%
src/dialect/mod.rs 1 2 50.0%
src/dialect/postgresql.rs 1 2 50.0%
src/parser/mod.rs 4 5 80.0%
tests/sqlparser_postgres.rs 19 21 90.48%
src/ast/value.rs 14 17 82.35%
src/tokenizer.rs 39 53 73.58%
Files with Coverage Reduction New Missed Lines %
src/ast/value.rs 1 86.96%
Totals Coverage Status
Change from base Build 10144601977: -0.04%
Covered Lines: 27277
Relevant Lines: 30585

💛 - Coveralls

@lovasoa
Copy link
Contributor Author

lovasoa commented Jul 27, 2024

I think the failed "lint" test is not related to the changes in this PR.

@git-hulk
Copy link
Member

I think the failed "lint" test is not related to the changes in this PR.

Yes, I also mentioned in #1353 (comment)

@lovasoa
Copy link
Contributor Author

lovasoa commented Jul 28, 2024

I opened a separate PR for the clippy errors: #1357

@lovasoa
Copy link
Contributor Author

lovasoa commented Jul 29, 2024

@alamb , I just merged the ci fixes from main, the CI passes, this should be good to merge.

@alamb alamb changed the title add support for postgres String Constants with Unicode Escapes Support for postgres String Constants with Unicode Escapes Jul 29, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lovasoa and @git-hulk

@alamb alamb merged commit bc15f7b into apache:main Jul 29, 2024
10 checks passed
mcheshkov pushed a commit to cube-js/sqlparser-rs that referenced this pull request Sep 2, 2024
Can drop this after rebase on commit bc15f7b "Support for postgres String Constants with Unicode Escapes (apache#1355)", first released in 0.50.0
mcheshkov pushed a commit to cube-js/sqlparser-rs that referenced this pull request Sep 3, 2024
Can drop this after rebase on commit bc15f7b "Support for postgres String Constants with Unicode Escapes (apache#1355)", first released in 0.50.0
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Unicode string literals prefixed with U&
4 participants