fix: allow arbitrary operators with ANY and ALL on Postgres #1842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sqlparser PR #963 a check was introduced which limits which operators can be used with
ANY
andALL
expressions.Postgres can parse more (possibly all binary operators, investigation pending) in this location. Postgres only seems to care that the operator yields a boolean - which is a semantic error, not a syntax (parse) error.
Example of semantic error in Postgres:
FWIW, the Postgres
pg_trgm
extension provides support for the%
where left and right args aretext
and it returns aboolean
- which makes it useable withANY
andALL
.The following code in
src/parser/mod.rs:2893-2908
is where the allowlist of operators is enforced: