Postgresql ALTER TABLE operation: REPLICA IDENTITY #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
May 10, 2025
There was a problem hiding this comment.
Thanks @MohamedAbdeen21! left a couple minor comments, the changes look good to me overall
| @@ -208,6 +229,12 @@ pub enum AlterTableOperation { | |||
| old_partitions: Vec<Expr>, | |||
| new_partitions: Vec<Expr>, | |||
| }, | |||
| /// REPLICA IDENTITY { DEFAULT | USING INDEX index_name | FULL | NOTHING } | |||
| /// | |||
| /// Note: this is a PostgreSQL-specific operation. | |||
There was a problem hiding this comment.
Can we add a link to the docs ideally so folks can easily find where the syntax comes from?
| @@ -39,6 +39,27 @@ use crate::ast::{ | |||
| use crate::keywords::Keyword; | |||
| use crate::tokenizer::Token; | |||
|
|
|||
| #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)] | |||
There was a problem hiding this comment.
It could be helpful here to add a description comment for the enum with a link to the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the psql-specific ALTER TABLE operation REPLICA IDENTITY
Docs: https://www.postgresql.org/docs/current/sql-altertable.html