Fix impl Ord for Ident
#1893
Merged
Fix impl Ord for Ident
#1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @eliaperantoni! Could you add some test cases to demonstrate the behavior being fixed? (Also there's some CI failures on the branch that need adressing it seems) |
|
@iffyio Thank you for your feedback! I added a test and fixed the CI issues :) |
iffyio
approved these changes
Jun 25, 2025
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the
Spanof anIdentis used influences its ordering, but this doesn't seem consistent with the implementations ofPartialEq,Hash, and the general guidelines for developing withSpan: that they should be opaque information that doesn't influence the ordering or equality of the AST nodes. Which is the reason whyTokenWithSpanwas born.This PR change the implementation of
Ordto ensure that it doesn't depend on theSpan.