Fix limit in subqueries

[Dimchikkk]

• Fixes Parse error for limit in subqueries #1898.

The bug was introduced in #1793 I think.

[iffyio]

LGTM! Thanks @Dimchikkk!
cc @alamb

[Dimchikkk]

@iffyio Thanks for merging.
@alamb Could this fix be backported to 0.56, or will DataFusion move straight to 0.57?

[alamb]

@iffyio Thanks for merging. @alamb Could this fix be backported to 0.56, or will DataFusion move straight to 0.57?

DataFusion hasn't updated to 0.56 yet

• Upgrade to sqlparser 0.56.0 datafusion#16405

Also, we haven't completed releasing 0.57.0 yet:

• Release sqlparser-rs version 0.57.0 around 2024-06-15 #1837

Maybe we should make a new release candidate for 0.57? Or make a fast 0.58 release?

[iffyio]

Ah yeah a new release candidate sounds reasonable given 0.57 isn't out yet

[Dimchikkk]

@alamb I'm aware that DataFusion isn’t on 0.56 yet. However, in order to upgrade it to 0.56, this fix would need to be backported. So I’m wondering: what’s the plan? Will this fix be backported to 0.56, or is DataFusion planning to skip 0.56 and move directly to 0.57 (or beyond)?

[alamb]

@alamb I'm aware that DataFusion isn’t on 0.56 yet. However, in order to upgrade it to 0.56, this fix would need to be backported. So I’m wondering: what’s the plan? Will this fix be backported to 0.56, or is DataFusion planning to skip 0.56 and move directly to 0.57 (or beyond)?

@Dimchikkk I don't have a plan myself -- I think it will be driven by someone who needs features of sqlparser in a new version of DataFusion. Perhaps you can help out and make a PR to upgrade?

Ah yeah a new release candidate sounds reasonable given 0.57 isn't out yet

I just completed the release of 0.57.0 given that each release takes a while to complete:

• Release sqlparser-rs version 0.57.0 around 2024-06-15 #1837

I would be happy to accelerate the timeline for 0.58.0 if that is helpful. Perhaps I can start making another release today / tomorrow?

• Release sqlparser-rs version 0.58.0 around 2024-08-15 #1886

What do you think @Dimchikkk and @iffyio ?

[alamb]

I didn't hold 0.57.0 as the bug wasn't introduced in 0.57.0 -- instead it seems to have been introduced in 0.56.0 -- so in my mind it makes sense to just keep pushing forward with the releases

[Dimchikkk]

@Dimchikkk I don't have a plan myself -- I think it will be driven by someone who needs features of sqlparser in a new version of DataFusion. Perhaps you can help out and make a PR to upgrade?

@alamb yeah, I have a PR for 0.56 here: apache/datafusion#16456, but it requires the current fix and #1905 to be backported to 0.56.