Skip to content

Conversation

Omega359
Copy link
Contributor

@Omega359 Omega359 commented Jan 11, 2025

  • Reran slt test completion using latest Datafusion
  • updated test completion code to switch from skipif Datafusion -> query error/statement error
  • switch from AS REAL to AS FLOAT8 to better match the actual meaning of REAL in sqlite
  • if DF errors and there are expected results the expected results are included in the comments

Test suite still fails because of apache/datafusion#13784 - Marked two tests as skipped with link to DF issue

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-14 at 7 03 42 AM

I skimmed this PR and the changes I could see look good to me

Let's get this in and move on

@alamb alamb merged commit 36283d1 into apache:main Jan 14, 2025
@alamb
Copy link
Contributor

alamb commented Jan 14, 2025

Thanks @Omega359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants