-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Closed
Copy link
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem or challenge?
- @Omega359 added the ability to run the sqlite sqlogictests suite against DataFusion in ❤️ Add sqlite test files, progress bar, and automatic postgres container management into sqllogictests #13936
However, at the moment it is only run manually and thus may start to fail without anyone knowing
Describe the solution you'd like
I would like to:
- Run the test regularly (perhaps on each commit to main)
- Make it clear what to do if the test fails
Describe alternatives you've considered
I would personally suggest adding a new workflow in
https://github.com/apache/datafusion/tree/main/.github/workflows
For example "extended.yml"
that only runs on each commit to main
Following the instructions here: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest#running-tests-sqlite
(aka I suggest using release-nonlto mode)
The job should make it clear what is going on if it fails -- aka add a comment like this that point people to the sqlogictest instructions:
datafusion/.github/workflows/dev.yml
Lines 43 to 45 in aafec07
# if you encounter error, rerun the command below and commit the changes | |
# | |
# ignore subproject CHANGELOG.md because they are machine generated |
Additional context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request