Implement Unparser for UNION ALL
#10603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 21, 2024
There was a problem hiding this comment.
Looks like a nice improvement to me. Thank you @phillipleblanc
| @@ -347,8 +373,33 @@ impl Unparser<'_> { | |||
|
|
|||
| Ok(()) | |||
| } | |||
| LogicalPlan::Union(_union) => { | |||
| not_impl_err!("Unsupported operator: {plan:?}") | |||
| LogicalPlan::Union(union) => { | |||
There was a problem hiding this comment.
I double checked that Union is UNION ALL https://docs.rs/datafusion/latest/datafusion/logical_expr/struct.Union.html
| @@ -4641,6 +4641,14 @@ fn roundtrip_statement() -> Result<()> { | |||
| group by "Last Name", p.id | |||
| having count_first_name>5 and count_first_name<10 | |||
| order by count_first_name, "Last Name""#, | |||
| r#"SELECT j1_string as string FROM j1 | |||
There was a problem hiding this comment.
Perhaps we should also add a test (as a follow on PR) for UNION (not UNION ALL)
y-f-u
pushed a commit
to spiceai/datafusion
that referenced
this pull request
May 22, 2024
This was referenced May 27, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
It doesn't close this issue, but is part of the work for #9494
Rationale for this change
Adds support for turning LogicalPlans that have
UnionLogicalPlans (without distinct, so onlyUNION ALL, notUNION) into SQL strings.It should be relatively easy now to support bare
UNIONby first inspecting theDistinctnode - but I ran out of time on this PR.What changes are included in this PR?
Splits
select_to_sqlinto two parts:select_to_sql_statementandselect_to_sql_expr. LIMIT and ORDER BY are only valid in a statement context, whereas all other plans can appear in a SELECT expression. This allows the parsing for UNION ALL to turn each of its inputs into a SELECT expression, and still respect the LIMIT/ORDER BY at the statement level.Are these changes tested?
Yes, added two tests to the
roundtrip_sqlintegration test.Are there any user-facing changes?
This expands the valid plans that can be unparsed back to SQL strings, and is backwards compatible.