Move handlign of NULL literals in where clause to type coercion pass #11491
Conversation
github-actions
bot
added
logical-expr
There was a problem hiding this comment.
Thank you for the follow up @xinlifoobar -- I think this works and is reasonable, though it is quite special case.
I left a suggestion on how to make this more general purpose, let me know what you think.
There was a problem hiding this comment.
Thanks -- sorry for the back and forth @xinlifoobar - I think we could make this simpler, But if you are sick of changing things, that is fine too and I can make a follow on PR
xinlifoobar
force-pushed
the
dev/xinli/null_lit_follow
branch
from
5809d74 to
e81fe1d
Compare
Ya, I am ok with this :) Sometimes I may make bad changes due to a lack of knowledge of the whole repo. You guidance is always helpful here. |
Thank you for understanding -- I feel bad when a PR is outstanding for a while due to lack of feedback or when we have to do multiple rounds of feedback when they each take a day. Also, thank you for all the help so far 🙏 |
alamb
changed the title
| if let LogicalPlan::Filter(filter) = &mut plan { | ||
| if let Ok(new_predicate) = filter | ||
| .predicate | ||
| .clone() |
There was a problem hiding this comment.
I found a way to avoid this clone: #11530
…pache#11491) * Revert "Support `NULL` literals in where clause (apache#11266)" This reverts commit fa01917. * Followup Support NULL literals in where clause * misc err change * adopt comparison_coercion * Fix comments * Fix comments
…pache#11491) * Revert "Support `NULL` literals in where clause (apache#11266)" This reverts commit fa01917. * Followup Support NULL literals in where clause * misc err change * adopt comparison_coercion * Fix comments * Fix comments
Which issue does this PR close?
Follow up #11266. This is to use
type_coercionfor null literary to avoid hard coding in physical planner.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?