re-export PartitionEvaluatorArgs from datafusion_expr::function #12878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to implement the WindowUDF trait.
findepi
approved these changes
Oct 11, 2024
|
Thanks @Michael-J-Ward |
alamb
approved these changes
Oct 14, 2024
|
FYI @jcsherin Thank you |
hailelagi
pushed a commit
to hailelagi/datafusion
that referenced
this pull request
Oct 14, 2024
…he#12878) This is needed to implement the WindowUDF trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to implement the WindowUDF trait.
Which issue does this PR close?
Closes #12877.
Rationale for this change
PartitionEvaluatorArgsis needed to implementWindowUDF, but is not currently re-exported.What changes are included in this PR?
PartitionEvaluatorArgsis re-exported indatafusion_expr::function.I placed it here because that is where
WindowUDFFieldArgsis re-exported.Are these changes tested?
N/A
Are there any user-facing changes?
Not from any released version.