Move HashJoin from RawTable to HashTable
#14904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
approved these changes
Feb 27, 2025
| self.map.allocation_info().1.size() + self.next.capacity() * size_of::<u64>() | ||
| let fixed_size = size_of::<PruningJoinHashMap>(); | ||
|
|
||
| estimate_memory_size::<(u64, u64)>(self.map.capacity(), fixed_size).unwrap() |
There was a problem hiding this comment.
maybe put a TODO here: once we updated the the latest hashbrown version, you no longer need to estimate this, see https://docs.rs/hashbrown/latest/hashbrown/struct.HashTable.html#method.allocation_size
|
Love it |
|
Thank you @Dandandan @jayzhan211 and @crepererum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
hashbrown::raw::RawTabletohashbrown::hash_table::HashTable#13433 the quest of @crepererumRationale for this change
Use some more HashTable, so we can upgrade (and benefit from further improvements).
I tested the benchmarks, I get no regressions (makes sense, as it is using similar APIs).
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?