(Re)Support old syntax for approx_percentile_cont and approx_percentile_cont_with_weight
#16999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ercentile_cont_with_weight
alamb
changed the title
approx_percentile_cont and approx_percentile_cont_with_weight
alamb
commented
Jul 31, 2025
| } else { | ||
| // User defined aggregate functions (UDAF) have precedence in case it has the same name as a scalar built-in function | ||
| if let Some(fm) = self.context_provider.get_aggregate_meta(&name) { | ||
| if fm.is_ordered_set_aggregate() && within_group.is_empty() { |
There was a problem hiding this comment.
there appears to be no tests for this error nor any reason I can see for not allowing it
alamb
commented
Jul 31, 2025
|
|
||
| # csv_query_approx_percentile_cont (c2, alternate syntax, should be the same as above) | ||
| query B | ||
| SELECT (ABS(1 - CAST(approx_percentile_cont(c2, 0.1) AS DOUBLE) / 1.0) < 0.05) AS q FROM aggregate_test_100 |
There was a problem hiding this comment.
now both the new and old queries work
crepererum
approved these changes
Aug 5, 2025
crepererum
requested changes
Aug 6, 2025
github-actions
bot
added
documentation
In 6c283df |
crepererum
approved these changes
Aug 11, 2025
|
Thanks again @crepererum |
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Aug 25, 2025
…ntile_cont_with_weight` (apache#16999) * Add sqllogictests * Allow both new and old sytanx for approx_percentile_cont and approx_percentile_cont_with_weight * Update docs * Add documentation and more tests
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Sep 5, 2025
…ntile_cont_with_weight` (apache#16999) * Add sqllogictests * Allow both new and old sytanx for approx_percentile_cont and approx_percentile_cont_with_weight * Update docs * Add documentation and more tests
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Sep 5, 2025
…ntile_cont_with_weight` (apache#16999) * Add sqllogictests * Allow both new and old sytanx for approx_percentile_cont and approx_percentile_cont_with_weight * Update docs * Add documentation and more tests
erratic-pattern
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 6, 2025
…ntile_cont_with_weight` (apache#16999) * Add sqllogictests * Allow both new and old sytanx for approx_percentile_cont and approx_percentile_cont_with_weight * Update docs * Add documentation and more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
approx_percentile_contandapprox_percentile_cont_with_weight#16955Rationale for this change
We had customers relying on the old syntax, and there appears to be no reason (or tests) that the old syntax is barred
What changes are included in this PR?
Remove the error that prevents runnings queries like this
Are these changes tested?
Yes, new sqllogictests are added
Are there any user-facing changes?
Yes, new (well, old) syntax is supported as well