-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update dev env documentation to reflect pinned rust version #17107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jefffrey -- this will cause all installations of DataFusion to download rust-analyzer, right? Even if it is just CI?
Does it work if you manually install rust-analyzer into the appropriate toolchain, like
rustup component add --toolchain 1.88 rust-analyzer
?
Yeah that would work, but I'm mainly thinking about people who might clone datafusion for the first time, they could run into a similar issue. Maybe it would be better to handle this via a documentation update? |
Updating the guide would make a lot of sense to me |
I've amended the documentation to reflect this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Jefffrey
@@ -75,18 +75,20 @@ Alternatively a binary release can be downloaded from the [Release Page](https:/ | |||
|
|||
DataFusion is written in Rust and it uses a standard rust toolkit: | |||
|
|||
- `rustup update stable` DataFusion generally uses the latest stable release of Rust, though it may lag when new Rust toolchains release | |||
- See which toolchain is currently pinned in the [`rust-toolchain.toml`](https://github.com/apache/datafusion/blob/main/rust-toolchain.toml) file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
I'm using helix, and the lsp integration wasn't working since it was trying to use the rust-analyzer component from the pinned toolchain, whilst I apparently only had rust-analyzer for latest toolchain.Let me know if there's a better solution for this 🙂Related: #14655
Update the documentation to reflect this edge case instead of requiring this new component for all CI runs