Skip to content

Conversation

Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Aug 10, 2025

I'm using helix, and the lsp integration wasn't working since it was trying to use the rust-analyzer component from the pinned toolchain, whilst I apparently only had rust-analyzer for latest toolchain.

Let me know if there's a better solution for this 🙂

Related: #14655

Update the documentation to reflect this edge case instead of requiring this new component for all CI runs

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jefffrey -- this will cause all installations of DataFusion to download rust-analyzer, right? Even if it is just CI?

Does it work if you manually install rust-analyzer into the appropriate toolchain, like

rustup component add --toolchain 1.88 rust-analyzer

?

@Jefffrey
Copy link
Contributor Author

Thanks @Jefffrey -- this will cause all installations of DataFusion to download rust-analyzer, right? Even if it is just CI?

Does it work if you manually install rust-analyzer into the appropriate toolchain, like

rustup component add --toolchain 1.88 rust-analyzer

?

Yeah that would work, but I'm mainly thinking about people who might clone datafusion for the first time, they could run into a similar issue. Maybe it would be better to handle this via a documentation update?

@alamb
Copy link
Contributor

alamb commented Aug 11, 2025

Yeah that would work, but I'm mainly thinking about people who might clone datafusion for the first time, they could run into a similar issue. Maybe it would be better to handle this via a documentation update?

Updating the guide
https://datafusion.apache.org/contributor-guide/development_environment.html

would make a lot of sense to me

@Jefffrey Jefffrey marked this pull request as draft August 12, 2025 08:08
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 12, 2025
@Jefffrey Jefffrey changed the title Add rust-analyzer component to rust-toolchain.toml Update dev env documentation to reflect pinned rust version Aug 12, 2025
@Jefffrey Jefffrey marked this pull request as ready for review August 12, 2025 08:25
@Jefffrey
Copy link
Contributor Author

Yeah that would work, but I'm mainly thinking about people who might clone datafusion for the first time, they could run into a similar issue. Maybe it would be better to handle this via a documentation update?

Updating the guide https://datafusion.apache.org/contributor-guide/development_environment.html

would make a lot of sense to me

I've amended the documentation to reflect this 👍

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Jefffrey

@@ -75,18 +75,20 @@ Alternatively a binary release can be downloaded from the [Release Page](https:/

DataFusion is written in Rust and it uses a standard rust toolkit:

- `rustup update stable` DataFusion generally uses the latest stable release of Rust, though it may lag when new Rust toolchains release
- See which toolchain is currently pinned in the [`rust-toolchain.toml`](https://github.com/apache/datafusion/blob/main/rust-toolchain.toml) file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Jefffrey Jefffrey merged commit 1e3152e into apache:main Aug 13, 2025
7 checks passed
@Jefffrey Jefffrey deleted the add-ra-to-toolchain branch August 13, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants