Refactor: Do not silently ignore errors in stats_projection
#17154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/do_not_ignore_erros
branch
from
61a5139 to
cee1f47
Compare
|
Many tests fail if we do not also include the fix in |
hareshkh
approved these changes
Aug 12, 2025
alamb
force-pushed
the
alamb/do_not_ignore_erros
branch
from
cee1f47 to
8854ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
@hareshkh tracked down a performance issue in the stats projection code where we were silently ignoring errors when evaluating the stats projection. This both
Let's not ignore errors silently, but instead return them to the caller.
What changes are included in this PR?
Are these changes tested?
Yes, by existing CI tests
Are there any user-facing changes?
No