fix: Prevent duplicate expressions in DynamicPhysicalExpr #17551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UBarney
force-pushed
the
dyn_filter_dedup
branch
from
62407e7 to
bd49372
Compare
UBarney
force-pushed
the
dyn_filter_dedup
branch
from
bd49372 to
4e78ba5
Compare
|
FYI @adriangb |
adriangb
approved these changes
Sep 16, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Refine
report_partition_boundsLogic inshared_bounds.rs:partitionparameter has been renamed to left_side_partition_id to clarify that it refers to the partition from the left (build) side.left_side_partition_idis identical to the previously recorded one. This directly fixes the issue inCollectLeftmode, where all streams report the sameleft_side_partition_idof0, thus preventing duplicate expressions.Are these changes tested?
Yes
Are there any user-facing changes?
No