feat(cli): support external tables on multiple locations #17702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
fpetkovski
force-pushed
the
multi-path-table
branch
from
3a5c9da to
a000dce
Compare
fpetkovski
commented
Sep 21, 2025
| state: &dyn Session, | ||
| cmd: &CreateExternalTable, | ||
| ) -> Result<Arc<dyn TableProvider>> { | ||
| let location = match cmd.locations.len() { |
There was a problem hiding this comment.
I wonder if there's a better way to constrain the API for this function to a single file location without throwing a runtime error if multiple are provided.
fpetkovski
force-pushed
the
multi-path-table
branch
from
74f2b5d to
599dc31
Compare
|
Thank you for this PR @fpetkovski -- I plan to review it carefully in the next day or two |
|
Thank you @alamb. I am aware of the CI issues and plan to address them. I was hoping to first get feedback on the overall direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-cli#16303Rationale for this change
The commit adds support for creating external tables that can reference multiple file locations. This is useful for querying files from multiple folders, or for scoping down an external table to specific files inside a single folder.
The change is implemented by splitting the location string on the
,delimiter as suggested in the original issue.Are these changes tested?
There is an added unit test for this change. I also did manual testing against the branch.
Are there any user-facing changes?
This feature does make a backwards compatible user-facing change, which should require documentation updates.