Skip to content

perf: boolean group values implementations #17726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

perf: boolean group values implementations #17726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24c1aee
chore: fix typos in group_values.
ashdnazg Sep 22, 2025
126817c
perf: add support for boolean columns in single and multi group by va…
ashdnazg Sep 22, 2025
04ee663
Merge branch 'main' into multi-group-builders
alamb Sep 25, 2025
c98922f
remove extra finish
ashdnazg Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions datafusion/physical-plan/src/aggregates/group_values/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ pub(crate) use single_group_by::primitive::HashValue;

use crate::aggregates::{
group_values::single_group_by::{
bytes::GroupValuesByes, bytes_view::GroupValuesBytesView,
primitive::GroupValuesPrimitive,
boolean::GroupValuesBoolean, bytes::GroupValuesBytes,
bytes_view::GroupValuesBytesView, primitive::GroupValuesPrimitive,
},
order::GroupOrdering,
};
Expand Down Expand Up @@ -119,7 +119,7 @@ pub trait GroupValues: Send {
/// - If group by single column, and type of this column has
/// the specific [`GroupValues`] implementation, such implementation
/// will be chosen.
///
///
/// - If group by multiple columns, and all column types have the specific
/// `GroupColumn` implementations, `GroupValuesColumn` will be chosen.
///
Expand Down Expand Up @@ -174,23 +174,26 @@ pub fn new_group_values(
downcast_helper!(Decimal128Type, d);
}
DataType::Utf8 => {
return Ok(Box::new(GroupValuesByes::<i32>::new(OutputType::Utf8)));
return Ok(Box::new(GroupValuesBytes::<i32>::new(OutputType::Utf8)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GroupValuesByes 🤦

}
DataType::LargeUtf8 => {
return Ok(Box::new(GroupValuesByes::<i64>::new(OutputType::Utf8)));
return Ok(Box::new(GroupValuesBytes::<i64>::new(OutputType::Utf8)));
}
DataType::Utf8View => {
return Ok(Box::new(GroupValuesBytesView::new(OutputType::Utf8View)));
}
DataType::Binary => {
return Ok(Box::new(GroupValuesByes::<i32>::new(OutputType::Binary)));
return Ok(Box::new(GroupValuesBytes::<i32>::new(OutputType::Binary)));
}
DataType::LargeBinary => {
return Ok(Box::new(GroupValuesByes::<i64>::new(OutputType::Binary)));
return Ok(Box::new(GroupValuesBytes::<i64>::new(OutputType::Binary)));
}
DataType::BinaryView => {
return Ok(Box::new(GroupValuesBytesView::new(OutputType::BinaryView)));
}
DataType::Boolean => {
return Ok(Box::new(GroupValuesBoolean::new()));
}
_ => {}
}
}
Expand Down
Loading